Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling libcxx 19, I noticed that libcalls to
__divsc3et al were emitted. These follow the C calling convention by default. I have provided a basic C implementation of these complex floating point routines so users will not get a linker error.Adding these functions also removes the need for the warning that
-ffast-mathis required when using C99<complex.h>. I have also added a very basic test to make sure that these complex CRT routines work for at least one input.The code also works on ez80-clang 15.0.0 so these can be back-ported if needed.
https://godbolt.org/z/daT41YeKP